Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2820#discussion_r226327006
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/MeasureRawColumnChunk.java
 ---
    @@ -94,7 +95,7 @@ public ColumnPage decodeColumnPage(int pageNumber) {
       public ColumnPage convertToColumnPageWithOutCache(int index) {
         assert index < pagesCount;
         // in case of filter query filter columns blocklet pages will 
uncompressed
    -    // so no need to decode again
    +    // so no need to decodeAndFillVector again
    --- End diff --
    
    seems no need to modify


---

Reply via email to