Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2829#discussion_r226722751
  
    --- Diff: format/src/main/thrift/carbondata.thrift ---
    @@ -206,6 +206,7 @@ struct FileFooter3{
         4: optional list<BlockletInfo3> blocklet_info_list3;   // Information 
about blocklets of all columns in this file for V3 format
         5: optional dictionary.ColumnDictionaryChunk dictionary; // Blocklet 
local dictionary
         6: optional bool is_sort; // True if the data is sorted in this file, 
it is used for compaction to decide whether to use merge sort or not
    +    7: optional map<string, string> extra_info; // written by is used to 
write who wrote the file, it can be Aplication name, or SDK etc and version in 
which this carbondata file is written etc
    --- End diff --
    
    for all the extra info, create map, it didnt get much of it, currently, it 
is map, and this suits for adding extra meta, and about changing test case, 
since those are the api level changes, we need to change those test cases.


---

Reply via email to