Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r226863651
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
 ---
    @@ -91,6 +93,25 @@ public void putArray(final int[] invertedIndex, final 
int[] invertedIndexReverse
         }
       }
     
    +  @Override
    +  public void fillVector(int[] invertedIndex, int[] invertedIndexReverse, 
byte[] data,
    +      ColumnVectorInfo vectorInfo) {
    +    this.invertedIndexReverse = invertedIndex;
    +
    +    // as first position will be start from 2 byte as data is stored first 
in the memory block
    +    // we need to skip first two bytes this is because first two bytes 
will be length of the data
    +    // which we have to skip
    +    int lengthSize = getLengthSize();
    +    // creating a byte buffer which will wrap the length of the row
    +    CarbonColumnVector vector = vectorInfo.vector;
    +    DataType dt = vector.getType();
    +    ByteBuffer buffer = ByteBuffer.wrap(data);
    +    BitSet deletedRows = vectorInfo.deletedRows;
    --- End diff --
    
    removed


---

Reply via email to