Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2834#discussion_r227194616
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -412,10 +413,13 @@ private void setCsvHeader(CarbonLoadModel model) {
public CarbonLoadModel buildLoadModel(Schema carbonSchema)
throws IOException, InvalidLoadOptionException {
timestamp = System.nanoTime();
- Set<String> longStringColumns = null;
- if (options != null && options.get("long_string_columns") != null) {
- longStringColumns =
- new
HashSet<>(Arrays.asList(options.get("long_string_columns").toLowerCase().split(",")));
+ Set<String> longStringColumns = new HashSet<>();
+ if (options != null &&
options.get(CarbonCommonConstants.LONG_STRING_COLUMNS) != null) {
--- End diff --
please add a comment to describe it is for long string
---
