Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2820#discussion_r227321710
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
 ---
    @@ -98,7 +98,11 @@ public BlockletFilterScanner(BlockExecutionInfo 
blockExecutionInfo,
       @Override
       public BlockletScannedResult scanBlocklet(RawBlockletColumnChunks 
rawBlockletColumnChunks)
           throws IOException, FilterUnsupportedException {
    -    return executeFilter(rawBlockletColumnChunks);
    +    if (blockExecutionInfo.isDirectVectorFill()) {
    +      return executeFilterForPages(rawBlockletColumnChunks);
    +    } else {
    +      return executeFilter(rawBlockletColumnChunks);
    --- End diff --
    
    ok, this would be big refactoring, we can consider in future PR


---

Reply via email to