Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2823#discussion_r227620200
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
---
@@ -48,7 +48,11 @@ public int getLengthFromBuffer(ByteBuffer buffer) {
public static AbstractNonDictionaryVectorFiller getVectorFiller(DataType
type, int lengthSize,
int numberOfRows) {
if (type == DataTypes.STRING) {
- return new StringVectorFiller(lengthSize, numberOfRows);
+ if (lengthSize > 2) {
--- End diff --
2 is magic number, can you change to constant or add a function to make it
more readable
---
