GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2851
[CARBONDATA-3040][BloomDataMap] Add checking before merging bloom index
*Scene*
There is a bug which causes query failure when we create two bloom datamaps
on same table with data.
*Analyse*
Since we already have data, each create datamap will trigger rebuild
datamap task and then trigger bloom index file merging. By debuging, we found
the first datamap's bloom index files would be merged two times and the second
time made bloom index file empty.
*Solution*
Send the datamap name in rebuild event for filter. And add file check when
merging.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata fix_multi_bloom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2851
----
commit bcab5ac630e39a7dadee09d5b9157642d061b5e1
Author: Manhua <kevinjmh@...>
Date: 2018-10-24T08:20:13Z
only rebuild target datamap and add file check
----
---
