Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228457234
--- Diff: store/CSDK/CarbonReader.cpp ---
@@ -74,27 +75,41 @@ jobject CarbonReader::withHadoopConf(char *key, char
*value) {
return carbonReaderBuilderObject;
}
+jobject CarbonReader::withBatch(int batch) {
+ jclass carbonReaderBuilderClass =
jniEnv->GetObjectClass(carbonReaderBuilderObject);
+ jmethodID buildID = jniEnv->GetMethodID(carbonReaderBuilderClass,
"withBatch",
--- End diff --
GetObjectClass shouldn't null, we should check whether
carbonReaderBuilderObject is null.
checked GetMethodID.
CallObjectMethodA of withBatch won't throw exception
---
