Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2850#discussion_r228706276
  
    --- Diff: 
store/sdk/src/test/java/org/apache/carbondata/sdk/file/ConcurrentSdkReaderTest.java
 ---
    @@ -0,0 +1,155 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.Callable;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.Future;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +
    +import junit.framework.TestCase;
    +import org.apache.commons.io.FileUtils;
    +import org.apache.commons.io.IOExceptionWithCause;
    +import org.junit.*;
    +
    +/**
    + * multi-thread Test suite for {@link CarbonReader}
    + */
    +public class ConcurrentSdkReaderTest extends TestCase {
    +
    +  private static final String dataDir = "./testReadFiles";
    +
    +  public void cleanTestData() {
    --- End diff --
    
    you can add @Before or @After got it. especially there are many test case


---

Reply via email to