Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228777044
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -1171,21 +1171,25 @@ object CarbonDataRDDFactory {
.ensureExecutorsAndGetNodeList(blockList, sqlContext.sparkContext)
val skewedDataOptimization = CarbonProperties.getInstance()
.isLoadSkewedDataOptimizationEnabled()
- val loadMinSizeOptimization = CarbonProperties.getInstance()
- .isLoadMinSizeOptimizationEnabled()
// get user ddl input the node loads the smallest amount of data
- val expectedMinSizePerNode = carbonLoadModel.getLoadMinSize()
- val blockAssignStrategy = if (skewedDataOptimization) {
- CarbonLoaderUtil.BlockAssignmentStrategy.BLOCK_SIZE_FIRST
- } else if (loadMinSizeOptimization) {
+ val carbonTable =
carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
+ var loadMinSize = carbonLoadModel.getLoadMinSize()
+ if (loadMinSize == "0" ) {
--- End diff --
for comparison for string, use String.equals instead of ==
---