Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2852#discussion_r228849744
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/sort/Sorter.java
 ---
    @@ -31,9 +32,10 @@
       /**
        * Initialize sorter with sort parameters.
        *
    +   * @param carbonTable
        * @param sortParameters
        */
    -  void initialize(SortParameters sortParameters);
    +  void initialize(CarbonTable carbonTable, SortParameters sortParameters);
    --- End diff --
    
    Do not modify the interface method to add CarbonTable. Instead hold the 
carbonTable object in SortParameters from which all classes extending Sorter 
interface can use carbonTable object


---

Reply via email to