[GitHub] carbondata pull request #2861: [CARBONDATA-3025]handle passing spark appname...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2861#discussion_r229285778
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala
 ---
    @@ -175,6 +172,11 @@ with Serializable {
               dataSchema: StructType,
               context: TaskAttemptContext): OutputWriter = {
             val model = 
CarbonTableOutputFormat.getLoadModel(context.getConfiguration)
    +        val appName = 
context.getConfiguration.get(CarbonCommonConstants.CARBON_WRITTEN_BY_APPNAME)
    +        if (null != appName) {
    --- End diff --
    
    Is there is no appName, I think we should construct one, the appName should 
be always write into the file


---