Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2887#discussion_r229670798
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java
 ---
    @@ -222,41 +220,24 @@ public void finish(CarbonFactHandler dataHandler) {
                 System.currentTimeMillis());
       }
     
    -  private void processingComplete(CarbonFactHandler dataHandler) throws 
CarbonDataLoadingException {
    +  private void processingComplete(CarbonFactHandler dataHandler) {
         if (null != dataHandler) {
    -      try {
    -        dataHandler.closeHandler();
    -      } catch (CarbonDataWriterException e) {
    -        LOGGER.error(e.getMessage(), e);
    -        throw new CarbonDataLoadingException(e.getMessage(), e);
    -      } catch (Exception e) {
    -        LOGGER.error(e.getMessage(), e);
    -        throw new CarbonDataLoadingException("There is an unexpected 
error: " + e.getMessage());
    --- End diff --
    
    Earlier here is the problem, we eat the original exception


---

Reply via email to