GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2889
[CARBONDATA-3067] Add check for debug to avoid string concat
For bloomfilter datamap, it will log debug for each blocklet. If the
data is huge, there maybe thousands of blocklet, so in this commit, we
will try to avoid necessary string concat if the debug level is not
enabled.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 101101_opt_debug_log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2889.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2889
----
commit d29cd6e38048851fc65ce1f713f534a51154385b
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-11-01T02:09:40Z
Add check for debug to avoid string concat
For bloomfilter datamap, it will log debug for each blocklet. If the
data is huge, there maybe thousands of blocklet, so in this commit, we
will try to avoid necessary string concat if the debug level is not
enabled.
----
---
