[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2875#discussion_r230618777
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -1744,89 +2021,101 @@ private CarbonCommonConstants() {
        * BYTE_ENCODING
        */
       public static final String BYTE_ENCODING = "ISO-8859-1";
    +
    --- End diff --
    
    carbon.push.rowfilters.for.vector is not in correct place and it should be 
dynamic=true


---