[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2875#discussion_r230630756
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -1744,89 +2021,101 @@ private CarbonCommonConstants() {
        * BYTE_ENCODING
        */
       public static final String BYTE_ENCODING = "ISO-8859-1";
    +
    --- End diff --
    
    move it to Query parameter, we can support dynamic=true for it in a new PR. 
There are others parameters like that.


---