Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2900#discussion_r231010174
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
 ---
    @@ -575,6 +576,8 @@ private BitSet setMatchedPartitions(String 
partitionIds, Expression filter,
        */
       public BlockMappingVO getBlockRowCount(Job job, CarbonTable table,
           List<PartitionSpec> partitions) throws IOException {
    +    // no useful information for count star query without filter, so 
disable explain collector
    +    ExplainCollector.remove();
    --- End diff --
    
    That's the weird part -- We are trying to remove the pruning collector even 
the pruning info is not initialized.
    I think you can add a flag for the collector to identify whether it is 
initialized. And this flag is used where carbon what to record the info. If you 
are planing to work like this, please add a comment for the scenario of this 
variable.


---

Reply via email to