Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232628355
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = 
"carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = 
Property.buildStringProperty()
    --- End diff --
    
    I think this should be boolean property


---

Reply via email to