Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2908#discussion_r233759450
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -1214,16 +1232,22 @@ public String getFormat() {
String tableName = tableInfo.getFactTable().getTableName();
String cacheColumns =
tableInfo.getFactTable().getTableProperties().get(CarbonCommonConstants.COLUMN_META_CACHE);
- if (null != cacheColumns && !cacheColumns.isEmpty()) {
- String[] cachedCols = cacheColumns.split(",");
- for (String column : cachedCols) {
- CarbonColumn carbonColumn = getColumnByName(tableName, column);
- if (null != carbonColumn && !carbonColumn.isInvisible()) {
- cachedColsList.add(carbonColumn.getColName());
+ if (null != cacheColumns) {
+ if (!cacheColumns.isEmpty()) {
+ String[] cachedCols = cacheColumns.split(",");
+ for (String column : cachedCols) {
+ CarbonColumn carbonColumn = getColumnByName(tableName, column);
+ if (null != carbonColumn && !carbonColumn.isInvisible()) {
+ cachedColsList.add(carbonColumn.getColName());
+ }
}
+ return cachedColsList;
+ } else {
+ return new LinkedList<>();
--- End diff --
I think it is not required to create `LinkedList` here. we can return
`cachedColsList` directly
---
