[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r235060209
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/MeasureColumnChunkReader.java
 ---
    @@ -56,13 +57,14 @@ MeasureRawColumnChunk readRawMeasureChunk(FileReader 
fileReader, int columnIndex
        * @return
        * @throws IOException
        */
    -  ColumnPage decodeColumnPage(MeasureRawColumnChunk measureRawColumnChunk,
    -      int pageNumber) throws IOException, MemoryException;
    +  ColumnPage decodeColumnPage(MeasureRawColumnChunk measureRawColumnChunk, 
int pageNumber,
    +      ReusableDataBuffer reusableDataBuffer) throws IOException, 
MemoryException;
     
       /**
        * Decode raw data and fill the vector
        */
    -  void decodeColumnPageAndFillVector(MeasureRawColumnChunk 
measureRawColumnChunk,
    -      int pageNumber, ColumnVectorInfo vectorInfo) throws IOException, 
MemoryException;
    +  void decodeColumnPageAndFillVector(MeasureRawColumnChunk 
measureRawColumnChunk, int pageNumber,
    +      ColumnVectorInfo vectorInfo, ReusableDataBuffer reusableDataBuffer)
    +      throws IOException, MemoryException;
    --- End diff --
    
    I have remove resuableBuffer from other two method for now as Reusable 
buffer code was only added for direct fill (new flow)


---