Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2954#discussion_r236634194
  
    --- Diff: 
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
 ---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.hiveexampleCI
    +
    +import org.apache.spark.sql.test.util.QueryTest
    +import org.scalatest.BeforeAndAfterAll
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.hiveexample.HiveExample
    +
    +class RunHiveExample extends QueryTest with BeforeAndAfterAll {
    +
    +  private val spark = sqlContext.sparkSession
    +
    +  override def beforeAll: Unit = {
    +    CarbonProperties.getInstance().addProperty(
    +      CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    +      CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT)
    +    CarbonProperties.getInstance().addProperty(
    +      CarbonCommonConstants.CARBON_DATE_FORMAT,
    +      CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT)
    +  }
    +
    +  test("HiveExample") {
    +    HiveExample.main(null)
    --- End diff --
    
    Don't call HiveExample.main directly, it better write some test cases.


---

Reply via email to