Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2975#discussion_r238989259
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ComplexQueryType.java
 ---
    @@ -29,6 +32,8 @@
     
       protected int blockIndex;
     
    +  protected Map<Integer, DimensionColumnPage> decodedPagesWithPageNumber = 
new HashMap<>();
    --- End diff --
    
    OK, I didn't mention the pageNumber and rowNumber
    
    > This map is to hold to DimensionColumnPage as we are decoding the same 
page again and again. 'byte[] data' for each row is the query result, we need 
to get that from the decodedPage
    
    OK, I didn't mention the pageNumber and rowNumber


---

Reply via email to