Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r239299140
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -156,20 +177,20 @@ object AlterTableDropPartitionPostStatusListener
extends OperationEventListener
// Generate table status file name without UUID, forExample:
tablestatus
val newTableSchemaPath =
CarbonTablePath.getTableStatusFilePath(
childCarbonTable.getTablePath)
- renameDataMapTableStatusFiles(oldTableSchemaPath,
newTableSchemaPath, uuid)
+ mergeTableStatusContents(oldTableSchemaPath,
newTableSchemaPath, uuid)
}
// if true then the commit for one of the child tables has failed
val commitFailed =
renamedDataMaps.lengthCompare(childCommands.length) != 0
if (commitFailed) {
LOGGER.info("Reverting table status file to original state")
- renamedDataMaps.foreach {
- command =>
- val carbonTable = command.table
- // rename the backup tablestatus i.e tablestatus_backup_UUID
to tablestatus
- val backupTableSchemaPath =
-
CarbonTablePath.getTableStatusFilePath(carbonTable.getTablePath) + "_backup_" +
uuid
- val tableSchemaPath =
CarbonTablePath.getTableStatusFilePath(carbonTable.getTablePath)
- renameDataMapTableStatusFiles(backupTableSchemaPath,
tableSchemaPath, "")
+ LOGGER.warn("Reverting table status file to original state")
--- End diff --
line 185 and 186 is repeated
---
