Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2981#discussion_r240026676
  
    --- Diff: 
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
 ---
    @@ -998,9 +999,19 @@ class SparkCarbonDataSourceTest extends FunSuite with 
BeforeAndAfterAll {
             i += 1
           }
           writer.close()
    -      spark.sql("create table complextable (stringfield string, 
structfield struct<bytefield: " +
    -                "byte, floatfield: float>) " +
    -                s"using carbon location '$path'")
    +      if (SparkUtil.isSparkVersionEqualTo("2.1")) {
    +        if (!FileFactory.isFileExist(path)) {
    +          FileFactory.createDirectoryAndSetPermission(path,
    +            new FsPermission(FsAction.ALL, FsAction.ALL, FsAction.ALL))
    +        }
    +        spark.sql("create table complextable (stringfield string, 
structfield struct<bytefield: " +
    +          "byte, floatfield: float>) " +
    +          s"using carbon options(path '$path')")
    +      } else if (SparkUtil.isSparkVersionXandAbove("2.2")) {
    --- End diff --
    
    it support 2.3, because it uses SparkUtil.isSparkVersionXandAbove.  


---

Reply via email to