Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2966#discussion_r241432600
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -2265,7 +2265,8 @@ public static int compareValues(byte[] filterValue,
byte[] minMaxBytes,
defaultValue = FilterUtil
.getMaskKey(key, currentBlockDimension,
segmentProperties.getSortColumnsGenerator());
} else {
- defaultValue = ByteUtil.toXorBytes(key);
+ defaultValue = FilterUtil
+ .getMaskKey(key, currentBlockDimension,
segmentProperties.getDimensionKeyGenerator());
--- End diff --
`if` and `else` has same code. remove if condition
---