Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2890#discussion_r241795430
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
 ---
    @@ -569,25 +569,25 @@ public static Dictionary 
getDictionary(AbsoluteTableIdentifier absoluteTableIden
           nodes.add(relation.getNode());
         }
     
    -    int noofNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
    +    int noOfNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
    --- End diff --
    
    I change noOfNodes to numOfNodes, there are more than 100+ place use 
numOf__,
    Do I need optimize noOfXXX to numOfXXX in similar code?


---

Reply via email to