[GitHub] carbondata pull request #2984: [CARBONDATA-3165]Protection of Bloom Null Exc...

[qiuchenjian]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2984#discussion_r241950006
  
    --- Diff: 
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
 ---
    @@ -227,6 +231,12 @@ private String getAncestorTablePath(CarbonTable 
currentTable) {
             }
           }
         }
    +    if (hitBlocklets == null) {
    +      LOGGER.warn(String.format("HitBlocklets is empty in bloom filter 
prune method. " +
    --- End diff --
    
    @jackylk empty sets present all blocklets are pruned, and null presents 
pruning is not effective,so it should return null.
    Now out datamap lack null processing（exception scene），it need to be 
enhanced later


---