Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242035462
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,52 @@ private static Schema readSchemaFromIndexFile(String
indexFilePath) throws IOExc
/**
* This method return the version details in formatted string by reading
from carbondata file
+ * If validate is true, it will check the version details between
different carbondata files.
+ * And if version details are not the same, it will throw exception
*
- * @param dataFilePath
- * @return
+ * @param path carbondata file path or folder path
+ * @param validate whether validate the version details between
different carbondata files.
+ * @return string with information of who has written this file
+ * in which carbondata project version
* @throws IOException
*/
- public static String getVersionDetails(String dataFilePath) throws
IOException {
+ public static String getVersionDetails(String path, boolean validate)
throws IOException {
--- End diff --
I think it is not correct to validate readability through version details.
In general new version jars can read all old version files.
Please remove this method.
---
