Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2713#discussion_r242393730
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -178,15 +178,9 @@ private String getAncestorTablePath(CarbonTable
currentTable) {
for (BloomQueryModel bloomQueryModel : bloomQueryModels) {
Set<Blocklet> tempHitBlockletsResult = new HashSet<>();
LOGGER.debug("prune blocklet for query: " + bloomQueryModel);
- BloomCacheKeyValue.CacheKey cacheKey = new
BloomCacheKeyValue.CacheKey(
- this.indexPath.toString(), bloomQueryModel.columnName);
- BloomCacheKeyValue.CacheValue cacheValue = cache.get(cacheKey);
- List<CarbonBloomFilter> bloomIndexList =
cacheValue.getBloomFilters();
- for (CarbonBloomFilter bloomFilter : bloomIndexList) {
- if (needShardPrune &&
!filteredShard.contains(bloomFilter.getShardName())) {
--- End diff --
Why delete the code of filtererShard.contains(bloomFilter.getShardName()),
I think this code can reduce time
---
