Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2897#discussion_r242629291
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
 ---
    @@ -94,10 +93,9 @@ public void fillVector(int[] invertedIndex, int[] 
invertedIndexReverse, byte[] d
       }
     
       @Override public void fillRow(int rowId, CarbonColumnVector vector, int 
vectorRow) {
    -    if (!dictionary.isDictionaryUsed()) {
    -      vector.setDictionary(dictionary);
    -      dictionary.setDictionaryUsed();
    -    }
    +    // always set dictionary otherwise
    +    // empty dictionary will get set if same col is called again in 
projection.
    +    vector.setDictionary(dictionary);
    --- End diff --
    
    1. For Session it is ok, issue happens only in SDK reader , Now hanlded in 
org.apache.carbondata.hadoop.util.CarbonVectorizedRecordReader.  
LocalDictDimensionDataChunkStore.java reverted back.
    2. OK. Done


---

Reply via email to