Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3005#discussion_r243150083
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
 ---
    @@ -95,15 +94,13 @@ public boolean renameForce(String changeToName) {
         FileSystem fs;
         try {
           fs = 
fileStatus.getPath().getFileSystem(FileFactory.getConfiguration());
    -      if (fs instanceof DistributedFileSystem) {
    -        ((DistributedFileSystem) fs).rename(fileStatus.getPath(), new 
Path(changeToName),
    -            org.apache.hadoop.fs.Options.Rename.OVERWRITE);
    -        return true;
    -      } else {
    -        return false;
    +      Path targetPath = new Path(changeToName);
    +      if (fs.exists(targetPath)) {
    +        fs.delete(targetPath, true);
    --- End diff --
    
    are there any risk for deleting path?


---

Reply via email to