Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r243164028
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
---
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.schema
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable
+
+import org.apache.spark.sql.{CarbonEnv, Row, SparkSession}
+import
org.apache.spark.sql.execution.command.{AlterTableDataTypeChangeModel,
DataTypeInfo,
+ MetadataCommand}
+import org.apache.spark.sql.hive.CarbonSessionCatalog
+import org.apache.spark.util.AlterTableUtil
+
+import
org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException
+import org.apache.carbondata.common.logging.LogServiceFactory
+import org.apache.carbondata.core.features.TableOperation
+import org.apache.carbondata.core.locks.{ICarbonLock, LockUsage}
+import
org.apache.carbondata.core.metadata.converter.ThriftWrapperSchemaConverterImpl
+import org.apache.carbondata.core.metadata.datatype.DecimalType
+import org.apache.carbondata.core.metadata.schema.table.CarbonTable
+import org.apache.carbondata.core.metadata.schema.table.column.CarbonColumn
+import
org.apache.carbondata.events.{AlterTableColRenameAndDataTypeChangePostEvent,
+ AlterTableColRenameAndDataTypeChangePreEvent, OperationContext,
OperationListenerBus}
+import org.apache.carbondata.format.{ColumnSchema, SchemaEvolutionEntry,
TableInfo}
+import org.apache.carbondata.spark.util.DataTypeConverterUtil
+
+abstract class CarbonAlterTableColumnRenameCommand(oldColumnName: String,
newColumnName: String)
+ extends MetadataCommand {
+
+ protected def validColumnsForRenaming(carbonColumns:
mutable.Buffer[CarbonColumn],
+ oldCarbonColumn: CarbonColumn,
+ carbonTable: CarbonTable): Unit = {
+ // check whether new column name is already an existing column name
+ if
(carbonColumns.exists(_.getColName.equalsIgnoreCase(newColumnName))) {
+ throw new MalformedCarbonCommandException(s"Column Rename Operation
failed. New " +
+ s"column name
$newColumnName already exists" +
+ s" in table ${
carbonTable.getTableName }")
+ }
+
+ // if the column rename is for complex column, block the operation
+ if (oldCarbonColumn.isComplex) {
+ throw new MalformedCarbonCommandException(s"Column Rename Operation
failed. Rename " +
+ s"column is unsupported
for complex datatype " +
+ s"column ${
oldCarbonColumn.getColName }")
+ }
+
+ // if column rename operation is on partition column, then fail the
rename operation
+ if (null != carbonTable.getPartitionInfo) {
+ val partitionColumns =
carbonTable.getPartitionInfo.getColumnSchemaList
+ partitionColumns.asScala.foreach {
+ col =>
+ if (col.getColumnName.equalsIgnoreCase(oldColumnName)) {
+ throw new MalformedCarbonCommandException(
+ s"Column Rename Operation failed. Renaming " +
+ s"the partition column $newColumnName is not " +
+ s"allowed")
+ }
+ }
+ }
+
+ }
+}
+
+private[sql] case class CarbonAlterTableColRenameDataTypeChangeCommand(
+ alterTableColRenameAndDataTypeChangeModel:
AlterTableDataTypeChangeModel)
+ extends
CarbonAlterTableColumnRenameCommand(alterTableColRenameAndDataTypeChangeModel.columnName,
+ alterTableColRenameAndDataTypeChangeModel.newColumnName) {
+
+ override def processMetadata(sparkSession: SparkSession): Seq[Row] = {
+ val LOGGER =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+ val tableName = alterTableColRenameAndDataTypeChangeModel.tableName
+ val dbName = alterTableColRenameAndDataTypeChangeModel.databaseName
+ .getOrElse(sparkSession.catalog.currentDatabase)
+ var isDataTypeChange = false
+ setAuditTable(dbName, tableName)
+ setAuditInfo(Map(
+ "column" -> alterTableColRenameAndDataTypeChangeModel.columnName,
+ "newColumn" ->
alterTableColRenameAndDataTypeChangeModel.newColumnName,
+ "newType" ->
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.dataType))
+ val locksToBeAcquired = List(LockUsage.METADATA_LOCK,
LockUsage.COMPACTION_LOCK)
+ var locks = List.empty[ICarbonLock]
+ // get the latest carbon table and check for column existence
+ var carbonTable: CarbonTable = null
+ var timeStamp = 0L
+ try {
+ locks = AlterTableUtil
+ .validateTableAndAcquireLock(dbName, tableName,
locksToBeAcquired)(sparkSession)
+ val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetaStore
+ carbonTable = CarbonEnv.getCarbonTable(Some(dbName),
tableName)(sparkSession)
+ if (!alterTableColRenameAndDataTypeChangeModel.isColumnRename &&
+ !carbonTable.canAllow(carbonTable,
TableOperation.ALTER_CHANGE_DATATYPE,
+ alterTableColRenameAndDataTypeChangeModel.columnName)) {
+ throw new MalformedCarbonCommandException(
+ "alter table change datatype is not supported for index datamap")
+ }
+ if (alterTableColRenameAndDataTypeChangeModel.isColumnRename &&
+ !carbonTable.canAllow(carbonTable,
TableOperation.ALTER_COLUMN_RENAME,
+ alterTableColRenameAndDataTypeChangeModel.columnName)) {
+ throw new MalformedCarbonCommandException(
+ "alter table column rename is not supported for index datamap")
+ }
+ val operationContext = new OperationContext
+ val alterTableColRenameAndDataTypeChangePreEvent =
+ AlterTableColRenameAndDataTypeChangePreEvent(sparkSession,
carbonTable,
+ alterTableColRenameAndDataTypeChangeModel)
+ OperationListenerBus.getInstance()
+ .fireEvent(alterTableColRenameAndDataTypeChangePreEvent,
operationContext)
+ val newColumnName =
alterTableColRenameAndDataTypeChangeModel.newColumnName.toLowerCase
+ val oldColumnName =
alterTableColRenameAndDataTypeChangeModel.columnName.toLowerCase
+ val carbonColumns =
carbonTable.getCreateOrderColumn(tableName).asScala.filter(!_.isInvisible)
+ if
(!carbonColumns.exists(_.getColName.equalsIgnoreCase(oldColumnName))) {
+ throwMetadataException(dbName, tableName, s"Column does not exist:
$oldColumnName")
+ }
+
+ val oldCarbonColumn =
carbonColumns.filter(_.getColName.equalsIgnoreCase(oldColumnName))
+ if (oldCarbonColumn.size != 1) {
+ throwMetadataException(dbName, tableName, s"Invalid Column:
$oldColumnName")
+ }
+ val newColumnPrecision =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
+ val newColumnScale =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
+ if (alterTableColRenameAndDataTypeChangeModel.isColumnRename) {
+ // validate the columns to be renamed
+ validColumnsForRenaming(carbonColumns, oldCarbonColumn.head,
carbonTable)
+ if (alterTableColRenameAndDataTypeChangeModel.isColumnRename) {
--- End diff --
above if loop is also checking for the same condition
---
