[GitHub] carbondata pull request #3006: [CARBONDATA-3187] Supported Global Dictionary...

[manishnalla1994]

Github user manishnalla1994 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3006#discussion_r243187905
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
    @@ -182,7 +182,7 @@ object GlobalDictionaryUtil {
           case None =>
             None
           case Some(dim) =>
    -        if (DataTypes.isArrayType(dim.getDataType)) {
    +        if (DataTypes.isArrayType(dim.getDataType) || 
DataTypes.isMapType(dim.getDataType)) {
    --- End diff --
    
    Yes, Map is implemented as Array of Struct internally.


---