Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2998#discussion_r243530847
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -331,7 +333,14 @@ object CarbonSource {
             properties,
             query)
           // updating params
    -      val updatedFormat = storageFormat.copy(properties = map)
    +      var updatedFormat: CatalogStorageFormat = null
    +      // For Spark version 2.2 and above, check if catalog table 
locationUri is empty, then assign
    +      // the value of tablepath to locationUri
    +      if (SparkUtil.isSparkVersionXandAbove("2.2") && 
tableDesc.storage.locationUri.isEmpty) {
    --- End diff --
    
    PLease add for 2.1 as well


---

Reply via email to