GitHub user manishnalla1994 opened a pull request:
https://github.com/apache/carbondata/pull/3022
[CARBONDATA-3196] Fixed Compaction for Complex types with Dictionary Include
Problem: Compaction Failing for Complex datatypes with Dictionary Include
as KeyGenenrator was not being set in model for Dictionary Include Complex
Columns and dictionary include complex columns were not handled for finding
cardinality.
Solution: Handled both these issues by setting KeyGenerator and storing
cardinality of Complex dictionary include columns.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishnalla1994/carbondata
ComplexCompactionIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3022
----
commit 874bc3b894c08b76f770722de543615edb45df19
Author: manishnalla1994 <manish.nalla1994@...>
Date: 2018-12-24T12:07:36Z
Fixed Compaction for Complex types with Dictionary Include
----
---
