[GitHub] carbondata pull request #3019: [CARBONDATA-3194] Integrating Carbon with Pre...

[qiuchenjian]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3019#discussion_r243822523
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
 ---
    @@ -113,7 +132,7 @@ private PrestoCarbonVectorizedRecordReader 
createReader(ConnectorSplit split,
           PrestoCarbonVectorizedRecordReader reader =
               new PrestoCarbonVectorizedRecordReader(queryExecutor, queryModel,
                   (AbstractDetailQueryResultIterator) iterator, readSupport);
    -      reader.setTaskId(carbondataSplit.getIndex());
    +      
reader.setTaskId(Long.parseLong(carbonSplit.getSchema().getProperty("index")));
    --- End diff --
    
    I think it‘s better to catch the NumberFormatException 


---