Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2919#discussion_r244102291
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java 
---
    @@ -241,12 +241,25 @@ private static Schema readSchemaFromIndexFile(String 
indexFilePath) throws IOExc
     
       /**
        * This method return the version details in formatted string by reading 
from carbondata file
    +   * default won't validate the version details between different 
carbondata files.
        *
    -   * @param dataFilePath
    -   * @return
    +   * @param path carbondata file path or folder path
    +   * @return string with information of who has written this file
    +   * in which carbondata project version
        * @throws IOException
        */
    -  public static String getVersionDetails(String dataFilePath) throws 
IOException {
    +  public static String getVersionDetails(String path) throws IOException {
    +    if (path.endsWith(INDEX_FILE_EXT)) {
    +      throw new RuntimeException("Can't get version details from 
carbonindex file.");
    --- End diff --
    
    IOException is from 
org.apache.carbondata.sdk.file.CarbonSchemaReader#getVersionDetailsFromDataFile,
  which is from org.apache.carbondata.core.datastore.FileReader#readByteBuffer, 
It's better to keep API, don't change it. @KanakaKumar 


---

Reply via email to