GitHub user manishnalla1994 opened a pull request:
https://github.com/apache/carbondata/pull/3047
[CARBONDATA-3223] Fixed Wrong Datasize and Indexsize calculation for old
store using Show Segments
Problem: Table Created and Loading on older version(1.1) was showing
data-size and index-size 0B when refreshed on new version. This was because
when the data-size was coming as "null" we were not computing it, directly
assigning 0 value to it.
Solution: Computed the correct data-size and index-size using CarbonTable.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishnalla1994/carbondata Datasize0Issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3047
----
commit 6bf65d7a0b42e8d9a822fd234a510550bd8d2f17
Author: manishnalla1994 <manish.nalla1994@...>
Date: 2019-01-02T12:30:36Z
Fixed Wrong Datasize and Indexsize calculation for old store
----
---
