Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3023#discussion_r245509625
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
    @@ -184,6 +184,9 @@ object CarbonEnv {
           .addListener(classOf[LoadTablePostExecutionEvent], new 
MergeIndexEventListener)
           .addListener(classOf[AlterTableCompactionPostEvent], new 
MergeIndexEventListener)
           .addListener(classOf[AlterTableMergeIndexEvent], new 
MergeIndexEventListener)
    +      .addListener(classOf[LoadTablePreStatusUpdateEvent], new 
MergeBloomIndexEventListener)
    --- End diff --
    
    yeah, that is supposed to be.
    
    Besides, I think it's framework's responsibility to include this procedure 
in the data-loading transaction. So the best practice is to optimize the 
framework's behavior.
    
    @jackylk How do you think about this. Should we do this in this PR or later?


---

Reply via email to