Github user shardul-cr7 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3045#discussion_r245516216
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
 ---
    @@ -110,7 +110,29 @@ case class PreAggregateTableHelper(
         // Datamap table name and columns are automatically added prefix with 
parent table name
         // in carbon. For convenient, users can type column names same as the 
ones in select statement
         // when config dmproperties, and here we update column names with 
prefix.
    -    val longStringColumn = 
tableProperties.get(CarbonCommonConstants.LONG_STRING_COLUMNS)
    --- End diff --
    
    This PR is for the scenario when user doesn't config the 
long_string_columns in dmprop then we take long_string_cols from the parent 
table.


---

Reply via email to