GitHub user manishnalla1994 opened a pull request:
https://github.com/apache/carbondata/pull/3056
[CARBONDATA-3236] Fix for JVM Crash for insert into new table from old table
Problem: Insert into new table from old table fails with JVM crash. This
happened because both the query and load flow were assigned the same taskId and
once query finished it freed the unsafe memory while the insert still in
progress.
Solution: As the flow for file format is direct flow and uses on-heap(safe)
so no need to free the unsafe memory.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishnalla1994/carbondata
JVMCrashForLoadAndQuery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3056
----
commit 150c710218ff3c09ccfccc9b2df970006964ef6d
Author: manishnalla1994 <manish.nalla1994@...>
Date: 2019-01-08T10:42:55Z
Fix for JVM Crash for file format
----
---
