Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3046#discussion_r246056127
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -2076,4 +2076,15 @@ private CarbonCommonConstants() {
        */
       public static final String 
CARBON_QUERY_DATAMAP_BLOOM_CACHE_SIZE_DEFAULT_VAL = "512";
     
    +  public static final String CARBON_LOCAL_DICTIONARY_MAX_THRESHOLD =
    --- End diff --
    
    It still failed to make it clear that what kind of size it supposed to be 
since we have a storage size and a counting size.


---

Reply via email to