Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246317841
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +613,9 @@ public static Dictionary
getDictionary(AbsoluteTableIdentifier absoluteTableIden
blockAssignmentStrategy =
BlockAssignmentStrategy.BLOCK_SIZE_FIRST;
} else {
blockAssignmentStrategy =
BlockAssignmentStrategy.BLOCK_NUM_FIRST;
+ // fall back to BLOCK_NUM_FIRST strategy need to reset
+ // the average expected size for each node
+ sizePerNode = numberOfBlocksPerNode;
--- End diff --
assignLeftOverBlocks also needs this similar if else self checks. I think
its ok, you can take a call to refactor now or later.
---
