Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3033#discussion_r247000712
  
    --- Diff: docs/datamap-developer-guide.md ---
    @@ -19,16 +19,16 @@
     
     ### Introduction
     DataMap is a data structure that can be used to accelerate certain query 
of the table. Different DataMap can be implemented by developers. 
    -Currently, there are two 2 types of DataMap supported:
    -1. IndexDataMap: DataMap that leverages index to accelerate filter query
    -2. MVDataMap: DataMap that leverages Materialized View to accelerate OLAP 
style query, like SPJG query (select, predicate, join, groupby)
    +Currently, there are two types of DataMap supported:
    +1. IndexDataMap: DataMap that leverages index to accelerate filter query, 
including Lucene DataMap and BloomFilter DataMap.
    --- End diff --
    
    I feel it is better to use "....acclerate filter query. Lucene DataMap and 
BloomFiler DataMap belongs to this type of DataMaps"
    
    similar to MV


---

Reply via email to