QiangCai commented on a change in pull request #3063: [CARBONDATA-3242] Move
Range_Column into the table level properties
URL: https://github.com/apache/carbondata/pull/3063#discussion_r248570562
##########
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
##########
@@ -219,24 +219,25 @@ case class CarbonLoadDataCommand(
carbonProperty.getProperty(CarbonCommonConstants.LOAD_SORT_SCOPE,
CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT))))))
- optionsFinal
- .put("bad_record_path",
CarbonBadRecordUtil.getBadRecordsPath(options.asJava, table))
- val factPath = if (dataFrame.isDefined) {
- ""
- } else {
- FileUtils.getPaths(factPathFromUser, hadoopConf)
- }
- carbonLoadModel.setParentTablePath(parentTablePath)
- carbonLoadModel.setFactFilePath(factPath)
-
carbonLoadModel.setCarbonTransactionalTable(table.getTableInfo.isTransactionalTable)
- carbonLoadModel.setAggLoadRequest(
- internalOptions.getOrElse(CarbonCommonConstants.IS_INTERNAL_LOAD_CALL,
- CarbonCommonConstants.IS_INTERNAL_LOAD_CALL_DEFAULT).toBoolean)
-
carbonLoadModel.setSegmentId(internalOptions.getOrElse("mergedSegmentName", ""))
- val columnCompressor =
table.getTableInfo.getFactTable.getTableProperties.asScala
- .getOrElse(CarbonCommonConstants.COMPRESSOR,
- CompressorFactory.getInstance().getCompressor.getName)
- carbonLoadModel.setColumnCompressor(columnCompressor)
+ optionsFinal
+ .put("bad_record_path",
CarbonBadRecordUtil.getBadRecordsPath(options.asJava, table))
+ val factPath = if (dataFrame.isDefined) {
+ ""
+ } else {
+ FileUtils.getPaths(factPathFromUser, hadoopConf)
+ }
+ carbonLoadModel.setParentTablePath(parentTablePath)
+ carbonLoadModel.setFactFilePath(factPath)
+
carbonLoadModel.setCarbonTransactionalTable(table.getTableInfo.isTransactionalTable)
+ carbonLoadModel.setAggLoadRequest(
+ internalOptions.getOrElse(CarbonCommonConstants.IS_INTERNAL_LOAD_CALL,
+ CarbonCommonConstants.IS_INTERNAL_LOAD_CALL_DEFAULT).toBoolean)
+
carbonLoadModel.setSegmentId(internalOptions.getOrElse("mergedSegmentName", ""))
+ val columnCompressor =
table.getTableInfo.getFactTable.getTableProperties.asScala
+ .getOrElse(CarbonCommonConstants.COMPRESSOR,
+ CompressorFactory.getInstance().getCompressor.getName)
+ carbonLoadModel.setColumnCompressor(columnCompressor)
+ carbonLoadModel.setRangePartitionColumn(table.getRangeColumn)
Review comment:
you found a bug of Github...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
