shardul-cr7 commented on a change in pull request #3070: [CARBONDATA-3246]Fix
sdk reader issue if batch size is given as zero and vectorRead False.
URL: https://github.com/apache/carbondata/pull/3070#discussion_r248580269
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##########
@@ -1523,5 +1529,30 @@ private void validateStringCharacterLimit() {
}
}
-
+ /**
+ * This method validates the DETAIL_QUERY_BATCH_SIZE. If some invalid input
is set, we use the
+ * default value for this property
+ */
+ private void validateDetailQueryBatchSize() {
+ String batchSizeString =
+
carbonProperties.getProperty(CarbonCommonConstants.DETAIL_QUERY_BATCH_SIZE);
+ if (batchSizeString == null) {
+ carbonProperties.setProperty(DETAIL_QUERY_BATCH_SIZE,
+
Integer.toString(CarbonCommonConstants.DETAIL_QUERY_BATCH_SIZE_DEFAULT));
+ LOGGER.info("Using default value for Query Batch Size " +
DETAIL_QUERY_BATCH_SIZE_DEFAULT);
+ } else {
+ int batchSize;
+ try {
+ batchSize = Integer.parseInt(batchSizeString);
+ if (batchSize <= 0) {
+ throw new NumberFormatException();
+ }
+ } catch (NumberFormatException ne) {
+ LOGGER.info(
+ "Invalid Query Batch size. Using default value " +
DETAIL_QUERY_BATCH_SIZE_DEFAULT);
+ int defaultBatchSize =
CarbonCommonConstants.DETAIL_QUERY_BATCH_SIZE_DEFAULT;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
