qiuchenjian commented on a change in pull request #3102: [CARBONDATA-3272]fix 
ArrayIndexOutOfBoundsException of horizontal compaction during update, when 
cardinality changes within a segment
URL: https://github.com/apache/carbondata/pull/3102#discussion_r251179211
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
 ##########
 @@ -140,25 +139,72 @@ public CarbonCompactionExecutor(Map<String, 
TaskBlockInfo> segmentMapping,
               || !CarbonCompactionUtil.isSorted(listMetadata.get(0));
       for (String task : taskBlockListMapping) {
         list = taskBlockInfo.getTableBlockInfoList(task);
 
 Review comment:
   suggest the change the variable name "list" to a meaningful name 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to