akashrn5 commented on a change in pull request #3102: [CARBONDATA-3272]fix
ArrayIndexOutOfBoundsException of horizontal compaction during update, when
cardinality changes within a segment
URL: https://github.com/apache/carbondata/pull/3102#discussion_r251324992
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
##########
@@ -140,25 +139,72 @@ public CarbonCompactionExecutor(Map<String,
TaskBlockInfo> segmentMapping,
|| !CarbonCompactionUtil.isSorted(listMetadata.get(0));
for (String task : taskBlockListMapping) {
list = taskBlockInfo.getTableBlockInfoList(task);
- Collections.sort(list);
- LOGGER.info(
- "for task -" + task + "- in segment id -" + segmentId + "- block
size is -" + list
- .size());
- queryModel.setTableBlockInfos(list);
- if (sortingRequired) {
- resultList.get(CarbonCompactionUtil.UNSORTED_IDX).add(
- new RawResultIterator(executeBlockList(list, segmentId, task,
configuration),
- sourceSegProperties, destinationSegProperties, false));
- } else {
- resultList.get(CarbonCompactionUtil.SORTED_IDX).add(
- new RawResultIterator(executeBlockList(list, segmentId, task,
configuration),
- sourceSegProperties, destinationSegProperties, false));
+ // during update there may be a chance that the cardinality may change
within the segment
Review comment:
this scenario came with update, in update the block level compaction happens
within a segment, and based on cardinality we calculate the bit length and then
create the keygenerator. so cardinality varies within a segment based on the
number of values being updated and based on that we generate the key, whose
keylength is diff in this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
