xubo245 opened a new pull request #3112: [CARBONDATA-3280] Fix the issue of SDK 
assert can't work
URL: https://github.com/apache/carbondata/pull/3112
 
 
   After #3097 merged, the batch rule has been changed, but the test didn't 
work, such as: 
   
   - org.apache.carbondata.sdk.file.CarbonReaderTest#testReadNextBatchRow
   - 
org.apache.carbondata.sdk.file.CarbonReaderTest#testReadNextBatchRowWithVectorReader
   
   So this PR fixed the test error and add some assert 
   
   Be sure to do all of the following checklist to help us incorporate 
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
    No
    - [ ] Any backward compatibility impacted?
    No
    - [ ] Document update required?
   No
    - [ ] Testing done
           Please provide details on 
           - Whether new unit test cases have been added or why no new tests 
are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance 
test report.
           - Any additional information to help reviewers in testing this 
change.
          
   fix test error
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
   No

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to