SteNicholas commented on a change in pull request #3116: [CARBONDATA-3229]Validate the true/false for all boolean parameters URL: https://github.com/apache/carbondata/pull/3116#discussion_r252278729
########## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ########## @@ -99,6 +65,11 @@ */ private Map<String, String> addedProperty = new ConcurrentHashMap<>(); + /** + * Boolean type properties default value + */ + Map<String, String> booleanProperties = new ConcurrentHashMap<>(); Review comment: @qiuchenjian Thank you for this suggestion,I forgot to add this modifier.This should add private modifier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services